Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tests: Python 3.13.0a6 renamed pathmod to parser #2702

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

befeleme
Copy link
Contributor

This fixes #2671 which reappeared in alpha6 as a result of upstream renaming the attribute.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

gaborbernat
gaborbernat previously approved these changes Apr 16, 2024
@gaborbernat gaborbernat enabled auto-merge (squash) April 17, 2024 00:09
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on Windows, can you address please.

@gaborbernat gaborbernat marked this pull request as draft April 17, 2024 00:19
auto-merge was automatically disabled April 17, 2024 00:19

Pull request was converted to draft

@befeleme
Copy link
Contributor Author

I see 4 failing checks (2x macos, ubuntu and docs), none can be attributed to these changes, windows tests pass. I don't know what to address.

@gaborbernat gaborbernat marked this pull request as ready for review April 17, 2024 14:44
@gaborbernat gaborbernat merged commit 97438d9 into pypa:main Apr 17, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpython3_win_embed test failures with Python 3.13
2 participants