Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad return code in bash activation if hashing is disabled #2717

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix bad return code in bash activation if hashing is disabled #2717

merged 1 commit into from
May 13, 2024
+10 −2

Commits on May 13, 2024

  1. Fix bad return code in bash activation if hashing is disabled 

    If hashing is disabled in bash, the `hash` command will return a nonzero
return code. Since it is the last command in the script that return code
will also be the "return code" of the source command, so if anyone uses

source activate.sh || die horribly

having hashing disabled will ruin their day.

Fix this by overriding the return code of `hash` if it's bad.
Add tests to verify a good return code and try with and without hashing.
    @fenkes-ibm
    fenkes-ibm committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ada5bd7 View commit details
    Browse the repository at this point in the history