limit filelock to highest compatible version #2736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filelock 3.15.0 was just released and causes the following crash when used with the latest version of virtualenv
```
Traceback (most recent call last):
File "/root/.pyenv/versions/3.10.11/lib/python3.10/site-packages/filelock/_api.py", line 365, in __del__
self.release(force=True)
File "/root/.pyenv/versions/3.10.11/lib/python3.10/site-packages/virtualenv/util/lock.py", line 34, in release
with self.thread_safe:
AttributeError: '_CountedFileLock' object has no attribute 'thread_safe'
```
This change avoids depending on this new incompatible version of filelock.
gaborbernat
requested changes
Jun 12, 2024
pyproject.toml
Outdated
| @@ -44,7 +44,7 @@ dynamic = [ | |||
| ] | |||
| dependencies = [ | |||
| "distlib<1,>=0.3.7", | |||
| "filelock<4,>=3.12.2", | |||
| "filelock<3.15,>=3.12.2", | |||
There was a problem hiding this comment.
I'd rather just disallow that version, not limit all future versions.
for more information, see https://pre-commit.ci
gaborbernat
approved these changes
Jun 12, 2024
|
Fixed via tox-dev/filelock#337 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filelock 3.15.0 was just released and causes the following crash when used with the latest version of virtualenv
This change avoids depending on this new incompatible version of filelock.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder