Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Solution to --python command-line flag precedence #2826

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

DK96-OS
Copy link
Contributor

@DK96-OS DK96-OS commented Jan 16, 2025

Update virtualenv/discovery/builtin.py

Simplify solution by operating on the sequence directly without creating a deque.

TODO

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

* Update virtualenv/discovery/builtin.py - simplify solution by operating on the sequence directly without creating a deque
@DK96-OS
Copy link
Contributor Author

DK96-OS commented Jan 16, 2025

I noticed this commit in the most recent release of virtualenv.

Reviewing the commit, I thought I could quickly simplify it.

@DK96-OS DK96-OS marked this pull request as ready for review January 17, 2025 15:43
@gaborbernat gaborbernat merged commit 56ef466 into pypa:main Jan 17, 2025
40 checks passed
@DK96-OS DK96-OS deleted the cli-precedence-2285 branch January 24, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants