Try to download the latest versions of preinstalled packages #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Will only accept Wheels (because that is all we can install without setuptools). * Will still fall back to using the bundled copies of the preinstalled packages if it cannot access the internet. This should prevent errors happening from too old of versions of software being bundled with virtualenv, while still allowing people to prevent talking to the internet with --no-download.
dstufft
added a commit
that referenced
this pull request
Jan 19, 2016
Try to download the latest versions of preinstalled packages
gtmanfred
added a commit
to gtmanfred/salt
that referenced
this pull request
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent errors happening from too old of versions of software being bundled with virtualenv, while still allowing people to prevent talking to the internet with
--no-download. Unlike the previous implementation of downloading which was insecure, this implementation simply allows pip to handle it, which makes it safe, secure, and fast when it's been cached.This should make issues like #835 better.
Fixes #801
Fixes #781
Fixes #563
Fixes #491