-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce correct ABI tags for GraalPy #557
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 72.35% 72.61% +0.26%
==========================================
Files 13 13
Lines 1085 1088 +3
==========================================
+ Hits 785 790 +5
+ Misses 300 298 -2
☔ View full report in Codecov by Sentry. |
@msimacek, can you add a test for this please ? |
Testing could be difficult as the |
This can be done with mocking like it is with PyPy: wheel/tests/test_bdist_wheel.py Lines 294 to 297 in 2bf5bb0
|
c079363
to
a28bc2c
Compare
73a5a57
to
bca1384
Compare
for more information, see https://pre-commit.ci
I added a test |
Please add a note to the changelog ( |
Added, thank you for assistance. |
Thanks! |
pypa/packaging#607 changed the ABI tag computation for GraalPy. This results in the current wheel not working for GraalPy because it uses pypa/packaging to validate tags of newly built wheels and now it always rejects them as mismatched. We need a corresponding change in wheel's tag computation, like it was done for PyPy in #373. Our SOABI look something like
graalpy231-310-native-x86_64-linux
, so the expected ABI tag for that isgraalpy231_310_native
. Compared to PyPy's there is one more component to distinguish native and sandboxed modes.CC @timfel