-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new ruff/pyupgrade rule UP032 #617
Conversation
UP032 Use f-string instead of `format` call
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 13 13
Lines 1083 1083
=======================================
Hits 770 770
Misses 313 313 ☔ View full report in Codecov by Sentry. |
This is being applied to |
Oops, didn't notice. I'll revert this. |
It's skipped here: Line 1 in 16206e6
So I'm assuming this was a native Ruff run. I'd recommend skipping it in Ruff's config too to avoid future issues. |
Yes, this was a native run. These lines were forgotten when changing from black to ruff: Lines 71 to 74 in 1e00742
Similar PRs have already been submitted to packaging: pypa/packaging#786 and pypa/packaging#787. |
This reverts commit 16206e6.
Not sure why CI jobs don't catch this, especially after updating ruff from 0.3.5 to 0.4.3 in 0b7771e.