Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new ruff/pyupgrade rule UP032 #617

Merged
merged 1 commit into from
May 9, 2024
Merged

Apply new ruff/pyupgrade rule UP032 #617

merged 1 commit into from
May 9, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

UP032 Use f-string instead of `format` call

Not sure why CI jobs don't catch this, especially after updating ruff from 0.3.5 to 0.4.3 in 0b7771e.

	UP032 Use f-string instead of `format` call
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.09%. Comparing base (0b7771e) to head (0bedde9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   71.09%   71.09%           
=======================================
  Files          13       13           
  Lines        1083     1083           
=======================================
  Hits          770      770           
  Misses        313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agronholm agronholm merged commit 16206e6 into pypa:main May 9, 2024
18 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the UP032 branch May 9, 2024 16:32
@henryiii
Copy link
Contributor

henryiii commented May 9, 2024

This is being applied to vendored/packaging. Pretty sure that dir should be skipped for linting and this PR should be made to packaging instead.

@agronholm
Copy link
Contributor

Oops, didn't notice. I'll revert this.

agronholm added a commit that referenced this pull request May 9, 2024
@henryiii
Copy link
Contributor

henryiii commented May 9, 2024

It's skipped here:

exclude: ^src/wheel/vendored

So I'm assuming this was a native Ruff run. I'd recommend skipping it in Ruff's config too to avoid future issues.

@DimitriPapadopoulos
Copy link
Contributor Author

Yes, this was a native run. These lines were forgotten when changing from black to ruff:

wheel/pyproject.toml

Lines 71 to 74 in 1e00742

[tool.black]
extend-exclude = '''
^/src/wheel/vendored/
'''

Similar PRs have already been submitted to packaging: pypa/packaging#786 and pypa/packaging#787.

seansmith39 pushed a commit to seansmith39/H6060-Python-wheel that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants