File searching bug

[kbwestfall]

This does a few minor things:

• Brings develop up to date with release after the 1.14.0 tag
• Fixes a bug in the error message when the code finds more than one file with the same name (but presumably different extensions).
• I'd like us to deprecate use of CHANGES and instead directly add to new "release" docs. Each time we do a release, I consolidate the listed changes into a doc and add it to our "What's New" page. I'm asking that we do that as we go now. If your change doesn't really fit under one of the existing headings, please add a new one. And, for each change, provide a narrative sentence or two explaining the change in a way that other developers (and eventually users) can understand. Other suggestions welcome.

[codecov-commenter]

Codecov Report

Merging #1678 (2b6db67) into develop (287f682) will increase coverage by 0.01%.
The diff coverage is 20.51%.

❗ Current head 2b6db67 differs from pull request most recent head 1ab1ef0. Consider uploading reports for the commit 1ab1ef0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1678      +/-   ##
===========================================
+ Coverage    40.96%   40.98%   +0.01%     
===========================================
  Files          189      189              
  Lines        43684    43667      -17     
===========================================
  Hits         17896    17896              
+ Misses       25788    25771      -17     

Files	Coverage Δ
pypeit/spectrographs/jwst_nirspec.py	30.92% <25.00%> (+0.62%)	⬆️
pypeit/spectrographs/keck_lris.py	13.25% <25.00%> (+0.03%)	⬆️
pypeit/spectrographs/lbt_mods.py	28.22% <25.00%> (+0.19%)	⬆️
pypeit/spectrographs/mmt_binospec.py	14.72% <25.00%> (+0.14%)	⬆️
pypeit/spectrographs/mmt_bluechannel.py	17.58% <25.00%> (+0.19%)	⬆️
pypeit/spectrographs/mmt_mmirs.py	20.00% <20.00%> (+0.24%)	⬆️
pypeit/spectrographs/keck_kcwi.py	30.07% <14.28%> (+0.22%)	⬆️
pypeit/utils.py	34.78% <14.28%> (+0.05%)	⬆️

[tbowers7]

Great stuff. One minor suggestion about adding to utils.find_single_file(), but approving now.

[tbowers7]

This is a really great idea -- and decreases the workload associated with tagging a release.

[tbowers7]

Having all of these headings for the developer to use is very helpful (rather than the semi-chronological order in CHANGES.rst).

[kbwestfall]

Following up on the call yesterday, I've updated the dev doc and added a section discussing how to do change logging now:

Logging changes
~~~~~~~~~~~~~~~

It is important to log changes made to the code in a way that other developers
and eventually users can interpret.  In the past we have done this using the
single ``CHANGES.rst`` file; however, we now have version specific change logs
in the ``doc/releases`` directory.  In terms of development guidelines:

- Changes made to the code should be logged in the relevant development log.
  For example, all changes made *after* version 1.14.0 will be logged in a
  ``doc/release/1.14.1dev.rst`` file.  If the relevant file doesn't exist when
  you submit your PR, create it.

- Changes are expected to fall under a small set of broad categories, like
  improvements to performance for specific instruments, minor bug fixes, or
  datamodel changes (see previous release docs for examples).  When including
  your change, add it below the relevant heading; if no relevant heading
  exists, add a new one.

- Hotfixes merged directly to the ``release`` branch should *also be added to
  the relevant development log*.  I.e., these changes are not part of the
  released tag, even if they are in the "release" branch.  Again, if the
  relevant file doesn't exist when you perform the hotfix, create it in a way
  that it will get merged with the identical doc in the ``develop`` branch.

- When tagging, the development log will be renamed to the new tag version, and
  a new file should be created for the next development phase.  See
  :ref:`tagging`.

Let me know if you have any questions or additions.

[rcooke-ast]

All good from me - just some minor comments to think about, and then merge when you're ready!

[rcooke-ast]

Great idea!