-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echelle improvements #1693
Echelle improvements #1693
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1693 +/- ##
========================================
Coverage 41.05% 41.05%
========================================
Files 189 189
Lines 43568 43570 +2
========================================
+ Hits 17888 17889 +1
- Misses 25680 25681 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. I only have a small comment.
Thanks for doing this @profxj!
tests started |
Test Summary--- PYTEST PYPEIT UNIT TESTS PASSED 239 passed, 70 warnings in 538.67s (0:08:58) --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things: One minor comment on the docstring; and a possible bug I randomly caught that might never get triggered, but makes the code misleading. Approving anyway.
Two changes in this short PR:
use_2dmodel_mask
for echelle spectrographs.reduce_bpm
in the final call to global_skyThe 2nd item was leading to crashes in Echelle data when an order had problems
during object finding.
No new tests or docs, but I am going to run the DevSuite.
And the new functionality has been tested on real world X-Shooter data.