Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypeit_show2dspec HOTFIX #1741

Merged
merged 1 commit into from
Dec 13, 2023
Merged

pypeit_show2dspec HOTFIX #1741

merged 1 commit into from
Dec 13, 2023

Conversation

tbowers7
Copy link
Collaborator

Change the default verbosity for pypeit_show_2dspec to 1 (which is where all the other scripts -- save run_pypeit -- are). This was an oversight in #1712.

Also, add new "scattlight" frametype to list of ignored frametypes for LDT/DeVeny.

modified:   pypeit/scripts/show_2dspec.py
modified:   pypeit/spectrographs/ldt_deveny.py

Change the default verbosity for `pypeit_show_2dspec` to 1 (which is
where all the other scripts -- save `run_pypeit` -- are).  This was
an oversight in #1712.

Also, add new "scattlight" frametype to list of ignored frametypes for
LDT/DeVeny.

	modified:   pypeit/scripts/show_2dspec.py
	modified:   pypeit/spectrographs/ldt_deveny.py
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (adbfbbf) 40.67% compared to head (31abb40) 40.67%.

Files Patch % Lines
pypeit/scripts/show_2dspec.py 0.00% 1 Missing ⚠️
pypeit/spectrographs/ldt_deveny.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1741   +/-   ##
========================================
  Coverage    40.67%   40.67%           
========================================
  Files          196      196           
  Lines        44648    44648           
========================================
  Hits         18159    18159           
  Misses       26489    26489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tbowers7 tbowers7 requested a review from profxj December 13, 2023 15:45
Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tbowers7 tbowers7 merged commit 4584d3a into develop Dec 13, 2023
23 checks passed
@tbowers7 tbowers7 deleted the show2dspec_hotfix branch December 13, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants