-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonlinearity correction + datacube spec1d extractions + datacube fluxing improvements #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pypeit/spectrographs/keck_deimos.py
# Conflicts: # doc/releases/1.15.1dev.rst
@rcooke-ast Please check my conflict resolution in the following:
|
Tweak edges using a gradient method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple updates (mostly in the context of KCWI/KCRM reductions).
Non-linearity correction
Based on commissioning data, I have calculated the non-linearity of KCWI (KCRM data are not currently available). I've also prepared a short document to describe the correction. See the following non-linearity report (pdf) for further details.
Datacube spec1d extractions
Introduced a new script that performs point source extractions from datacubes:
pypeit_extract_datacube
. This script producesspec1d
files including boxcar + optimal extractions that can then be used for flux calibration or science analysis (if observing point sources).Flux calibration
The flux calibration of datacubes has been moved to outside of the datacube generation. This allows the datacube generation to make use of the
pypeit_sensfunc
script. Note, there is a "bug" with the current approach to generating sensitivity functions. PypeIt only uses only one spec1d file (of a standard star) to generate the sensitivity function. The datacube module allows you to combine multiple standard star spec2d files into a single datacube. However, the extinction correction is performed on the extracted datacube - this means that the extinction correction cannot be performed on individual standard star spec2d files.extended a test for datacube and fluxing (+ docs)
I've redeveloped a test that tests the entire datacube creation process + added new docs. There is an associated
dev-suite PR as well.
Part of this PR addresses Issue #1701.
Tests pass: