Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinearity correction + datacube spec1d extractions + datacube fluxing improvements #1770

Merged
merged 128 commits into from
Jul 29, 2024

Conversation

rcooke-ast
Copy link
Collaborator

@rcooke-ast rcooke-ast commented Feb 15, 2024

This PR contains multiple updates (mostly in the context of KCWI/KCRM reductions).

Non-linearity correction
Based on commissioning data, I have calculated the non-linearity of KCWI (KCRM data are not currently available). I've also prepared a short document to describe the correction. See the following non-linearity report (pdf) for further details.

Datacube spec1d extractions
Introduced a new script that performs point source extractions from datacubes: pypeit_extract_datacube. This script produces spec1d files including boxcar + optimal extractions that can then be used for flux calibration or science analysis (if observing point sources).

Flux calibration
The flux calibration of datacubes has been moved to outside of the datacube generation. This allows the datacube generation to make use of the pypeit_sensfunc script. Note, there is a "bug" with the current approach to generating sensitivity functions. PypeIt only uses only one spec1d file (of a standard star) to generate the sensitivity function. The datacube module allows you to combine multiple standard star spec2d files into a single datacube. However, the extinction correction is performed on the extracted datacube - this means that the extinction correction cannot be performed on individual standard star spec2d files.

extended a test for datacube and fluxing (+ docs)
I've redeveloped a test that tests the entire datacube creation process + added new docs. There is an associated
dev-suite PR as well.

Part of this PR addresses Issue #1701.

Tests pass:
image

@kbwestfall
Copy link
Collaborator

@rcooke-ast Please check my conflict resolution in the following:

CONFLICT (content): Merge conflict in pypeit/core/flux_calib.py
CONFLICT (content): Merge conflict in pypeit/par/pypeitpar.py
CONFLICT (content): Merge conflict in pypeit/sensfunc.py

@rcooke-ast
Copy link
Collaborator Author

Tests pass...
image

@rcooke-ast rcooke-ast merged commit c2dca65 into develop Jul 29, 2024
23 checks passed
@rcooke-ast rcooke-ast deleted the kcwi_cube_updates branch July 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants