Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package dependency updates #1854

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Package dependency updates #1854

merged 8 commits into from
Sep 6, 2024

Conversation

kbwestfall
Copy link
Collaborator

Deprecates support for python <= 3.10. I also updated other package dependencies, trying to at least synchronize them to when 3.11 was released.

This also includes some doc fixes.

We'll need to run tests.

@kbwestfall
Copy link
Collaborator Author

PS - This also includes some updates to the installing doc.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.03%. Comparing base (745f36c) to head (9ef8b39).
Report is 55 commits behind head on develop.

Files with missing lines Patch % Lines
pypeit/spectrographs/vlt_xshooter.py 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1854      +/-   ##
===========================================
+ Coverage    38.01%   38.03%   +0.02%     
===========================================
  Files          210      211       +1     
  Lines        48850    48975     +125     
===========================================
+ Hits         18569    18629      +60     
- Misses       30281    30346      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kbwestfall!!

Copy link
Collaborator

@rcooke-ast rcooke-ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need to change tox.ini? Otherwise, this all looks great to me - thanks for doing this!

@kbwestfall
Copy link
Collaborator Author

Do you also need to change tox.ini? Otherwise, this all looks great to me - thanks for doing this!

Can you say more? The PR has changes to tox.ini, but did I miss something?

@rcooke-ast
Copy link
Collaborator

Do you also need to change tox.ini? Otherwise, this all looks great to me - thanks for doing this!

Can you say more? The PR has changes to tox.ini, but did I miss something?

Ahhh... sorry - I didn't see it at the bottom of the PR. All looks good to me!!

@kbwestfall
Copy link
Collaborator Author

Do you also need to change tox.ini? Otherwise, this all looks great to me - thanks for doing this!

Can you say more? The PR has changes to tox.ini, but did I miss something?

Ahhh... sorry - I didn't see it at the bottom of the PR. All looks good to me!!

Phew! Thanks for checking.

@profxj profxj merged commit 081f2f4 into develop Sep 6, 2024
18 checks passed
@kbwestfall kbwestfall deleted the dep310 branch September 6, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants