Hfb test and windows to.csv() tpl write fix
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started adding this test ages back after running into issues with my hfb template files.
Turns out my issue was related to a pandas update (0.24) where the line end interpretation had changes for windows (see pandas-dev/pandas#25048)
So this PR also includes the (tiny) fix for that issue. When opening the file handle for writing (and eventually writing with
pandas.to_csv()) we need to explicitly set the newline argument tonewline = ''. Otherwise line terminators get written twice when writing out the csv.Hopefully this wont have any unintented consequences for those on more sensible OS.