Use a hash based file paths on *new* uploads #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a file path like {pyver}/{name[0]}/{name}/{filename}, we will
instead use one that looks like {hash[:2]}/{hash[2:4]}/{hash[4:]}{filename},
where `hash` is the blake2b(digest_size=32) hex digest (lowercased) of the
actual file contents. This will ensure that the contents referred to by a
specific file URL cannot change without also changing the URL.
This also adds File.blake2_256_digest to hold this new hash.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a file path like
{pyver}/{name[0]}/{name}/{filename}, we will instead use one that looks like{hash[:2]}/{hash[2:4]}/{hash[4:]}{filename}, wherehashis the blake2b(digest_size=32) hex digest (lowercased) of the actual file contents. This will ensure that the contents referred to by a specific file URL cannot change without also changing the URL.This also adds
File.blake2_256_digestto hold this new hash.