Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oidc] Make 'trusted publishers' generally available #13460

Merged
merged 7 commits into from
Apr 20, 2023
Merged

[oidc] Make 'trusted publishers' generally available #13460

merged 7 commits into from
Apr 20, 2023

Conversation

di
Copy link
Member

@di di commented Apr 20, 2023 •
edited
Loading

This takes the 'trusted publishers' feature out of beta. The only thing left to do is drop the has_oidc_beta_access column from the Users model, but will do that in a follow-up PR.

Fixes #12965.

@di di requested a review from a team as a code owner April 20, 2023 17:30
@di di mentioned this pull request Apr 20, 2023
Merged
miketheman
miketheman approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note to remove the preview feature from the docs. Otherwise this looks functionally correct.

warehouse/templates/manage/account/publishing.html Show resolved Hide resolved
@di di merged commit 99dfe53 into pypi:main Apr 20, 2023
@di di deleted the trusted-publishers-ga branch April 20, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
trusted-publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closed beta for OIDC publishing
3 participants
@di @miketheman @woodruffw