Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Observers and Observations models #14834

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

miketheman
Copy link
Member

Here's a draft of Observers, Observations.

I've applied the mixin to Project, Release models so far, and only added Admin visibility into Projects.
There's a bunch of TODOs in there, and any pointers for concrete solutions would be much appreciated!

Take it for a whirl, try it out, let me know what you think.

@miketheman miketheman added HTML requires change to HTML files admin Features needed for the Admin UI (people running the site) labels Oct 31, 2023
@miketheman miketheman requested a review from a team as a code owner October 31, 2023 22:07
@miketheman miketheman force-pushed the miketheman/observers branch 2 times, most recently from f09f586 to 362b422 Compare November 2, 2023 14:43
@miketheman miketheman force-pushed the miketheman/observers branch 4 times, most recently from 539000f to 384cafc Compare November 8, 2023 19:47
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
I'm going to be adding another view for releases, keep this specific.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman force-pushed the miketheman/observers branch from 384cafc to 4df4a8a Compare November 9, 2023 19:57
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman requested a review from ewdurbin November 9, 2023 20:04
@miketheman miketheman requested a review from di November 17, 2023 14:25
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miketheman miketheman merged commit c20a241 into pypi:main Nov 20, 2023
14 checks passed
@miketheman miketheman deleted the miketheman/observers branch November 20, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Features needed for the Admin UI (people running the site) HTML requires change to HTML files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants