metadata: initial PEP 753 bits #17470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
di
reviewed
Feb 7, 2025
Signed-off-by: William Woodruff <william@trailofbits.com>
di
approved these changes
Feb 10, 2025
|
🤦 The PyPUG URL is too long for the linting rules. I'll swap it with the PEP URL, since that one links to the PyPUG one anyways. |
Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty small change, to get some initial bits of PEP 753 into Warehouse.
In particular, the only real functional change here is the addition of the
metadata.normalize_project_url_labelhelper and its use inRelease.urls(instead of the previous ad-hoc normalization). This doesn't actually change the presentation based on the normalized labels (yet!) -- I'll do that in a follow-up.The other changes in this PR are mostly auto-formatting (I can remove these if desired), as well as fixing an import cycle between
warehouse.forklift.metadataandwarehouse.packaging.models-- I fixed the latter by separatingDynamicFieldsEnuminto a DB-levelENUMtype in themodels, which gets populated from data stored inforklift.metadata. That keeps the import flow unidirectional and seems conceptually consistent to me, versus importing a DB model intoforklift.metadata🙂