Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manylinux2014 wheel upload #6684

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Sep 22, 2019

manylinux2014 platform tag is official per PEP599

see also pypa/manylinux#338

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that PEP 599 adds support for a number of additional architectures besides x86_64 and i686, they will need to be added as well.

@mayeut
Copy link
Contributor Author

mayeut commented Sep 23, 2019

@di,
I forced-pushed an updated commit with all architectures except armhfp.
Can you confirm the detection code in PEP599 has been tested on all platforms ?
linux-armhfp won't be returned on some platforms (if not all, depending on previous answer)

Simple test I did:

docker pull arm32v7/centos:7
docker run --rm -it arm32v7/centos:7 /bin/bash
[root@36ef319dca55 /]# uname -a
Linux 36ef319dca55 4.9.184-linuxkit #1 SMP Tue Jul 2 22:58:16 UTC 2019 armv7l armv7l armv7l GNU/Linux
[root@36ef319dca55 /]# python
Python 2.7.5 (default, Oct 31 2018, 20:11:09) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-36)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.uname()
('Linux', '36ef319dca55', '4.9.184-linuxkit', '#1 SMP Tue Jul 2 22:58:16 UTC 2019', 'armv7l')
>>> from distutils.util import get_platform
>>> get_platform()
'linux-armv7l'

This also means that there is no difference between armhfp and armsfp (the later being uncommon these days), what shall I do ?

@di di mentioned this pull request Sep 27, 2019
@di
Copy link
Member

di commented Sep 27, 2019

@mayeut It was not tested it seems. I've made python/peps#1181 to update the PEP.

@di di added the blocked Issues we can't or shouldn't get to yet label Sep 27, 2019
@di
Copy link
Member

di commented Sep 27, 2019

@auvipy, while I appreciate your review, if you don't see any issues would you mind reserving approvals for maintainers? Otherwise it just generates noise. Thanks!

manylinux2014 platform tag is official per PEP599

see also pypa/manylinux#338
@mayeut
Copy link
Contributor Author

mayeut commented Sep 27, 2019

@di, I updated the PR with armv7l. Given the PR you made for the PEP, I guess you've made up your mind on the soft-float vs hard-float ABI incompatibility and that we should consider glibc 2.17+ and armv7l to always be hard-float ABI then. Thanks.

@di di removed the blocked Issues we can't or shouldn't get to yet label Sep 30, 2019
@di di merged commit e1d0e4e into pypi:master Sep 30, 2019
@mayeut mayeut deleted the manylinux2014-pep599 branch April 25, 2020 12:39
@mayeut mayeut mentioned this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants