Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_deprecated and get_non_deprecated() to CRS #1383

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Add is_deprecated and get_non_deprecated() to CRS #1383

merged 6 commits into from
Feb 29, 2024

Conversation

jjimenezshaw
Copy link
Contributor

@jjimenezshaw jjimenezshaw commented Feb 26, 2024 •
edited
Loading

This PR adds two methods:

  • is_deprecated
  • get_non_deprecated

To replicate the functionality in PROJ C API.

snowman2
snowman2 reviewed Feb 29, 2024
View reviewed changes
pyproj/_crs.pyx Outdated Show resolved Hide resolved
snowman2
snowman2 reviewed Feb 29, 2024
View reviewed changes
pyproj/_crs.pyx Outdated Show resolved Hide resolved
@snowman2 snowman2 added this to the 3.6.2 milestone Feb 29, 2024
@snowman2
Copy link
Member

Looks great 👍. Seems like there are unrelated failures. So, should be good to go after the minor changes.

jjimenezshaw and others added 2 commits February 29, 2024 09:40
@jjimenezshaw @snowman2
is_deprecated added in 3.7.0
ce282fa 
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
@jjimenezshaw @snowman2
get_non_deprecated added in 3.7.0
a188b87 
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
jjimenezshaw
jjimenezshaw commented Feb 29, 2024
View reviewed changes
pyproj/crs/crs.py Outdated Show resolved Hide resolved
pyproj/crs/crs.py Outdated Show resolved Hide resolved
@snowman2 snowman2 merged commit 0461d9f into pyproj4:main Feb 29, 2024
9 of 19 checks passed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Oct 1, 2024
geography/py-proj: Update to 3.7.0
2c3ac40 
(Tests fail with environment issues, but one can load pyproj outside
of the test environment.  Filed upstream.)

Enhancements:
* PERF: drop GIL during long-running proj database calls by @tpwrules in pyproj4/pyproj#1354
* PERF: thread local context by @snowman2 in pyproj4/pyproj#1419
* ENH: Add is_deprecated and get_non_deprecated() to CRS by @jjimenezshaw in pyproj4/pyproj#1383
* ENH: Add runtime & compiled PROJ versions by @snowman2 in pyproj4/pyproj#1427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowman2 snowman2 snowman2 left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

Support for deprecated and non-deprecated objects
2 participants
@jjimenezshaw @snowman2