ENH: Added pyproj.network.set_ca_bundle_path #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I am going to move most of the code to python to be able to mock and add appropriate tests later. |
snowman2
force-pushed
the
ca_bundle_path
branch
from
0c507f6
to
063b51e
Compare
snowman2
changed the title
snowman2
force-pushed
the
ca_bundle_path
branch
from
063b51e
to
5c06b13
Compare
This was referenced Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #689
Enabled with: OSGeo/PROJ#2320
history.rstfor all changes andapi/*.rstfor new APIWasn't able to find a great way to test this. If you build PROJ against the system curl, I think it is able to find the CA Bundle path pretty well even if an invalid path is added. And not able to mock cython stuff. The main goal is for wheels to not break. So, if the wheel build passes then it should be fine.