Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Skip transformations if 'noop' & deprecate 'skip_equivalent' #824

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

snowman2
Copy link
Member

  • Tests added
  • Fully documented, including history.rst for all changes and api/*.rst for new API

Skip equivalent/exact same is not needed. This means that one less CRS object is needed when re-creating _Transformer across threads.

>>> from pyproj import CRS, Transformer
>>> crs = CRS(4326)
>>> tr = Transformer.from_crs(crs.to_proj4(), "+init=epsg:4326")
>>> tr.name
'noop'
>>> CRS(crs.to_proj4()) == "+init=epsg:4326"
True
>>> CRS(crs.to_proj4()).is_exact_same("+init=epsg:4326")
False

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #824 (5a8a13f) into master (9818912) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files          21       21           
  Lines        1652     1655    +3     
=======================================
+ Hits         1572     1575    +3     
  Misses         80       80           
Impacted Files Coverage Δ
pyproj/transformer.py 95.93% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9818912...5a8a13f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant