Adding filter support to all appenders implementing UnsynchronizedAppenderBase #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is passing for oraclejdk8 and openjdk7. The failing part is installing oraclejdk7: install-jdk.sh 2019-01-18 II
Expected feature release number in range of 9 to 13, but got: 7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm not sure how to implement filter support as an extension on my side. The way I did it was to implement the
build-appenderand thestart-appender!function for every type of appender I want to use. I feel like adding it to the library makes it simpler.Would you be interested in that PR ? I could also add the filter instantiation in the
build-appendermethod if you prefer.What do you think ?