Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcore #2088

Merged
merged 109 commits into from
Aug 13, 2024
Merged

netcore #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
63f86ea
add net8.0-window targetframework
dosymep Feb 13, 2024
794190b
update dependencies path
dosymep Feb 13, 2024
db13a9a
remove runtime outdated links
dosymep Feb 13, 2024
d77c139
remove unnecessary build configurations
dosymep Feb 13, 2024
18ecfc3
fix slashes
dosymep Feb 14, 2024
698038f
add revit 2025 libraries
dosymep Feb 14, 2024
68af819
add revit 2016-2024 versions documentation
dosymep Feb 14, 2024
1b1afdc
add revit 2025 project
dosymep Feb 14, 2024
05bdc2d
add revit versions props
dosymep Feb 14, 2024
1cc2e50
update projects files
dosymep Feb 14, 2024
385cfe4
fix pyrevit runtime build
dosymep Feb 15, 2024
fa4e7d7
fix pyrevitLoader build
dosymep Feb 15, 2024
979c529
fix pyRevitLabs build
dosymep Feb 15, 2024
d09467c
Merge branch 'develop' into dosymep/netcore
dosymep Feb 19, 2024
431d70f
fix configuration revit runtime 2025
dosymep Feb 19, 2024
284098d
make all configurations to x64
dosymep Feb 19, 2024
d2940f8
remove revit api docs
dosymep Feb 19, 2024
2e61b9b
fix compile
dosymep Feb 27, 2024
5634d41
fix ambiguous MenuItem, ContextMenu
dosymep Feb 28, 2024
828c64d
add compiled libs net8.0
dosymep Feb 28, 2024
a043449
remove deprecated engines
dosymep Feb 28, 2024
9c22d71
fix build 2025
dosymep Feb 28, 2024
e9c6347
fix resove dependencies
dosymep Apr 1, 2024
aa68900
update projects
dosymep Apr 1, 2024
a55d535
update dependencies
dosymep Apr 1, 2024
6aac378
update dependencies
dosymep Apr 1, 2024
3425766
fix build
dosymep Apr 1, 2024
6458428
update
dosymep Apr 4, 2024
ecbe93f
update
dosymep Apr 4, 2024
a28853e
update build test
dosymep Apr 4, 2024
6221a00
update build
dosymep Apr 4, 2024
6077561
add build-deps.yml
dosymep Apr 4, 2024
159a6fb
update build-deps.yml
dosymep Apr 4, 2024
e1c757e
update build-deps.yml
dosymep Apr 4, 2024
959b008
update build-deps.yml
dosymep Apr 4, 2024
18b27f1
update build-deps.yml
dosymep Apr 4, 2024
9fc97e8
update pyRevitLoader build
dosymep Apr 10, 2024
bc500a3
update pyRevitLabs.PyRevit.Runtime build
dosymep Apr 10, 2024
e8a9db1
fix warnings in pyRevitLams.PyRevit.Runtime
dosymep Apr 10, 2024
74faf7a
fix warnings in pyRevitLabs
dosymep Apr 10, 2024
c11bdc8
fix build pyRevitCLI
dosymep Apr 10, 2024
b25fb25
update build scripts
dosymep Apr 10, 2024
6b418ef
remove build-deps.yml
dosymep Apr 10, 2024
e6f888e
update revit deps to released libs
dosymep Apr 10, 2024
384bc06
removed OR_LESS constants
dosymep Apr 10, 2024
e6dc0d9
update revit define constants
dosymep Apr 12, 2024
007ba33
update revit references
dosymep Apr 12, 2024
e5e81c2
update loaders
dosymep Apr 16, 2024
f36b9f6
update .gitignore (089c3c6d90cd86b498b3e393ab719cedfa051808)
dosymep Apr 16, 2024
507d1ab
add deps
dosymep Apr 16, 2024
1f5d08d
add build runtime
dosymep Apr 16, 2024
f884fd8
update git modules
dosymep Apr 17, 2024
c63681d
update git modules
dosymep Apr 17, 2024
359e51f
try update CI-CD
dosymep Apr 17, 2024
5e086e8
try update CI-CD
dosymep Apr 17, 2024
176a9f8
try update CI-CD
dosymep Apr 17, 2024
af80f88
try update CI-CD
dosymep Apr 17, 2024
8e67cdc
try update CI-CD
dosymep Apr 17, 2024
36e33c4
try update CI-CD
dosymep Apr 17, 2024
d8830e6
try update CI-CD
dosymep Apr 17, 2024
a8a456a
try update CI-CD
dosymep Apr 17, 2024
923df50
try update CI-CD
dosymep Apr 17, 2024
88ba089
try update CI-CD
dosymep Apr 17, 2024
96e3491
try update CI-CD
dosymep Apr 17, 2024
de95a37
try update CI-CD
dosymep Apr 17, 2024
039fa77
try update CI-CD
dosymep Apr 17, 2024
b932d9f
try update CI-CD
dosymep Apr 17, 2024
5404e8f
try update CI-CD
dosymep Apr 17, 2024
432e8dc
try update CI-CD
dosymep Apr 17, 2024
c6b0c25
try update CI-CD
dosymep Apr 17, 2024
5d4e770
try update CI-CD
dosymep Apr 17, 2024
8cc49c1
try update CI-CD
dosymep Apr 17, 2024
fb00500
try update CI-CD
dosymep Apr 17, 2024
adfa1c3
apply patch
dosymep Jun 3, 2024
5e2d31b
fix version
dosymep Jun 3, 2024
2b734f0
fix resolve version
dosymep Jun 3, 2024
be31cd7
add pyRevitLoader.py
dosymep Jun 3, 2024
616500c
fix python std libs
dosymep Jun 3, 2024
c2b4d72
add to use compiled runtime library
dosymep Jun 18, 2024
d022709
update net folder path to netfx or netcore
dosymep Jun 18, 2024
fef0451
add load netcore libraries in revit 2025 or above
dosymep Jun 18, 2024
4014e57
fix throwing exception when dependency was loaded in netcore runtime
dosymep Jun 18, 2024
5899344
add net folder name
dosymep Jun 19, 2024
3a896e6
add generate assembly for Revit 2025
dosymep Jun 19, 2024
b819672
update MadMilkman.Ini reference
dosymep Jun 22, 2024
fef8315
update refs libs
dosymep Jun 22, 2024
a2a4a98
fix builds
dosymep Jun 22, 2024
368baba
fix builds
dosymep Jun 22, 2024
64b98f8
bump version to 5.0.0
dosymep Jun 22, 2024
2933c14
fix build
dosymep Jun 23, 2024
4bf9ae4
fix build
dosymep Jun 23, 2024
3afa0d7
update workflow
dosymep Jun 23, 2024
b6f6e6e
update workflow
dosymep Jun 23, 2024
a81fd2d
fix build
dosymep Jun 23, 2024
6266420
fix build
dosymep Jun 23, 2024
2d70cdd
Update pyrevit-hosts.json
jmcouffin Jun 24, 2024
82b38b4
fix build
dosymep Jun 24, 2024
71cc7ab
Merge remote-tracking branch 'origin/dosymep/netcore' into dosymep/ne…
dosymep Jun 24, 2024
ef56004
move python.net to libraries, fix ironpython versions, update to cpyt…
Jun 24, 2024
5d8eb85
build: ensure mahappsmetro xaml styles
Jul 28, 2024
9fe5ae8
fix: installer doesn't create the addin files
Aug 12, 2024
311e15c
fix: wrong cpython engines paths
Aug 12, 2024
6a00a08
build: add configuration parameter to some pyrevit build commands
Aug 12, 2024
7d15802
fix: avoid python builtins overwrite
Aug 12, 2024
83fbf08
refactor: use linq and simplify engin searches
Aug 12, 2024
7b3b254
build: fix pyrevit build product script default config
Aug 12, 2024
76bef4f
fix: cannot find netcore engines
Aug 12, 2024
3ec046d
feat(cli): non-zero exit code on error
Aug 12, 2024
3eed7c7
Squashed and merged develop 4 changes to dosymep/netcore fork and branch
jmcouffin Aug 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# These are supported funding model platforms

github: # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
patreon: pyrevit
open_collective: # Replace with a single Open Collective username
patreon: # pyrevit
open_collective: pyrevitlabs
ko_fi: # Replace with a single Ko-fi username
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
Expand Down
49 changes: 0 additions & 49 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md

This file was deleted.

70 changes: 70 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
---
name: Bug report
description: Thanks for taking the time to report a bug!
title: "[Bug]: "
labels: [Bug]
body:
- type: markdown
attributes:
value: |
> **🚧 If you have SentinelOne installed as an antivirus, look no further.**
> **You will need to create exceptions for Revit and pyRevit, both on the software and the %appdata% folders.**
- type: checkboxes
id: preflight
attributes:
label: ✈ Pre-Flight checks
description: before submitting an issue, make sure you've checked the following
options:
- label: I **don't have SentinelOne** antivirus installed (see above for the solution)
required: true
- label: I have **searched in the issues** (open and closed) but couldn't find a similar issue
required: true
- label: I have **searched in the [pyRevit Forum](https://discourse.pyrevitlabs.io)** for similar issues
required: true
- label: I already **followed the [installation troubleshooting guide](https://pyrevitlabs.notion.site/Installation-issues-f6495adb56254e9e8021f8a68e3b2ab7) thoroughly**
required: true
- label: I am using the **latest pyRevit Version**
required: true
- type: textarea
id: description
attributes:
label: 🐞 Describe the bug
description: Be as specific as possible and list steps to reproduce the issue.
validations:
required: true
- type: textarea
id: error-message
attributes:
label: ⌨ Error/Debug Message
description: If you have any suggestions for the solution, please list that as well. Issues related to tools/scripts, I tried to run them in debug mode (CTRL+click on the button) and copy over the contents of the output window.
render: shell
validations:
required: true
- type: textarea
id: reproduce-steps
attributes:
label: ♻️ To Reproduce
description: Steps to reproduce the behavior
placeholder: |
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
- type: textarea
id: expected-behavior
attributes:
label: ⏲️ Expected behavior
description: A clear and concise description of what you expected to happen.
- type: textarea
id: env
attributes:
label: 🖥️ Hardware and Software Setup (please complete the following information)
description: Open a command prompt 🖥 and run the command `pyrevit env`. Paste the output here.
render: shell
validations:
required: true
- type: textarea
id: context
attributes:
label: Additional context
description: Add any other context about the problem here.
22 changes: 13 additions & 9 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
---
name: Feature request
about: Suggest an idea for this project

labels: "New Feature"
---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
## Is your feature request related to a problem? Please describe

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when... -->

## Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. -->

## Describe alternatives you've considered

**Describe the solution you'd like**
A clear and concise description of what you want to happen.
<!-- A clear and concise description of any alternative solutions or features you've considered. -->

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
## Additional context

**Additional context**
Add any other context or screenshots about the feature request here.
<!-- Add any other context or screenshots about the feature request here. -->
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
blank_issues_enabled: false
17 changes: 12 additions & 5 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,22 @@ updates:
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"
interval: "monthly"
# Check for npm updates on Sundays
day: "sunday"
# Raise pull requests for version updates
# to pip against the `develop` branch
target-branch: "develop"
# to pip against the `develop-4` branch
target-branch: "develop-4"
- package-ecosystem: "gomod"
# directory required https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#vendor
directory: "/"
target-branch: "develop"
target-branch: "develop-4"
schedule:
interval: "weekly"
interval: "monthly"
# Set update schedule for GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every week
interval: "monthly"
target-branch: "develop-4"
27 changes: 27 additions & 0 deletions .github/slash-commands.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
issues:
more-info:
label:
- needs-more-info

install-fix:
comment: >
Hi @{{ author }}, Try these steps:

1. Uninstall pyRevit

2. Delete C:\ProgramData and %AppData%\ pyRevit and pyrevit-master folders

3. Move all Revit addins to a temporary location. Usual addins locations include:
- %AppData%\Autodesk\Revit\Addins<year>
- %AppData%\Autodesk\ApplicationPlugins
- %ProgramData%\Autodesk\Revit\Addins<year>
- %ProgramData%\Autodesk\ApplicationPlugins

4. [Reboot computer]

5. Reinstall pyRevit

6. Started each version of Revit confirming pyRevit successfully compiled at startup.

7. Move all Revit addins that were moved in step 3 back to their original location.
You may want to add them one at a time and start a revit session everytime to figure out which ones are causing the issue.
44 changes: 37 additions & 7 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,54 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.head_ref }}

- name: Checkout Submodules
uses: snickerbockers/submodules-init@7ce9774442c0c2d4728e6d3f66141df2102e4cbc
submodules: recursive

- name: Prepare Python 3.10
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

- name: Prepare pipenv
run: |
pip install pipenv
pipenv install

# needs for MahApps XamlColorSchemeGenerator
- name: Prepare .NET 3.1
uses: actions/setup-dotnet@v4
with:
dotnet-version: 3.1.x

- name: Prepare .NET 8.0
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x

- name: Prepare msbuild
uses: microsoft/setup-msbuild@v1.1
uses: microsoft/setup-msbuild@v2

- name: Build Products
run: |
pipenv run pyrevit build products

- name: Build Installers
run: |
pipenv run pyrevit build installers

- name: Get Install Version
id: installversion
uses: juliangruber/read-file-action@v1
with:
path: release/version

- name: Upload Installers
uses: actions/upload-artifact@v4
with:
name: pyrevit-installers
path: |
dist/pyRevit_${{ steps.installversion.outputs.content }}_signed.exe
dist/pyRevit_${{ steps.installversion.outputs.content }}_admin_signed.exe
dist/pyRevit_CLI_${{ steps.installversion.outputs.content }}_signed.exe
dist/pyRevit_CLI_${{ steps.installversion.outputs.content }}_admin_signed.exe
dist/pyRevit_CLI_${{ steps.installversion.outputs.content }}_admin_signed.msi
dist/pyrevit-cli.${{ steps.installversion.outputs.content }}.nupkg
14 changes: 12 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,31 @@ on:
push:
branches:
- docs
paths:
- 'mkdocs.yml'
- 'docs/**'
- 'pyrevitlib/**'
- '*.md'
# when PR from develop->master is created
pull_request:
branches:
- master
paths:
- 'mkdocs.yml'
- 'docs/**'
- 'pyrevitlib/**'
- '*.md'
# manual run
workflow_dispatch:

jobs:
docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Prepare Python 3.10
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/issues-manager.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: issues-manager
on:
issue_comment:
types: [created]

jobs:
issue_commented:
runs-on: ubuntu-latest
steps:
- name: Custom Slash Commands
uses: wow-actions/slash-commands@v1.1.0
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CONFIG_FILE: .github/slash-commands.yml

- name: Pending Response Follow Up
uses: siegerts/pending-response@v1.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
pending-response-label: needs-more-info
Loading