Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use ILRepack for single dll builds #2346

Closed
wants to merge 7 commits into from

Conversation

sanzoghenzo
Copy link
Contributor

Hi, this is a draft before I leave for a short vacation...

I tried to add ILRepack task after the build, but it complains about not finding RevitAPI (which should be excluded, but it thows the error anyway).

I used this package, but I suppose that the complexity of our folder structure gets in our way...

Here an article on the subject as reference.

@jmcouffin jmcouffin added the pyRevit 5 pyRevit 5 coming release label Aug 15, 2024
@sanzoghenzo
Copy link
Contributor Author

Ok, I got to the point that each pyRevitLabs.PyRevit.Runtime.YYYY.dll contains all the dependencies, but they are around 30MB each!

I suppose it is better to use ILRepack on the other pyRevitLabs projects to embed only the 3rd party dependencies...

@sanzoghenzo
Copy link
Contributor Author

This is as far as I can get with my MSBuild knowledge...
I tried to repack the CLI, but it errors out with a wrong path that I don't know how to change.

Now that I think of it, the CLI is the last of our problems, but this is just a test to see if this could be done.

@dosymep when you can, would you like to give it a try?

@dosymep
Copy link
Member

dosymep commented Aug 22, 2024

@sanzoghenzo

I think it's better not to solve this problem with ILRepack, our build process is already complicated, and this will add even more problems. It's better to focus on fixing errors in the work in the 2025 version, excluding the problem with dependencies (let it be so for now)

@sanzoghenzo
Copy link
Contributor Author

I was trying to test if ILRepack works as of now, to then decide to drop all the modules altogether and use the official nuget packages instead of our custom one.

But if you think is less complicated to sort out dependencies first, it's fine with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pyRevit 5 pyRevit 5 coming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants