Refactor MonteCarlo to be a StatefulInterpretation #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
commented
Sep 27, 2020
Comment on lines
+359
to
+360
| def __call__(self, cls, *args): | ||
| return self.dispatch(cls, *args)(self, *args) |
There was a problem hiding this comment.
This default implementation of __call__() is a partial function, and relies on InterpreterStack to fall back to the previous interpretation, which is by assumption complete.
fritzo
commented
Sep 27, 2020
fritzo
commented
Sep 27, 2020
eb8680
approved these changes
Sep 28, 2020
| @@ -324,13 +333,54 @@ def dispatched_interpretation(fn): | |||
| return fn | |||
|
|
|||
|
|
|||
| class StatefulInterpretationMeta(type): | |||
There was a problem hiding this comment.
I guess this is required for Python 3.5? Once we drop Python 3.5 support, we should remove this and other metaclasses where possible in favor of __init_subclass__.
There was a problem hiding this comment.
Agreed, I was almost tempted to drop support for Python 3.5 in this PR, but that seemed like overkill.
This was referenced Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair coded with @eb8680
@eb8680 I have adapted
StatefuleInterpretationfrom https://github.com/pyro-ppl/funsor/tree/adam-interpreter, making it anamedtupleas you had originally suggested, and turning on fallback logic by default as you suggested.This PR:
StatefulInterpretationbase class for interpretations that need to pass instance-specific data such as num_samples and rng_key.InterpreterStackand makes theMonteCarlointerpretation fall back not toeagerbut the previous interpretation when it was installed.monte_carloto a statefulMonteCarlo.MonteCarloby trackingrng_key@fehiepsi can you help me out with this?