support ExpandedDistribution for jax backend #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
reviewed
Jan 9, 2021
| if get_backend() == "jax": | ||
| _expanded_dist_path = "backend_dist.ExpandedDistribution" | ||
| elif get_backend() == "torch": | ||
| _expanded_dist_path = "backend_dist.torch_distribution.ExpandedDistribution" |
There was a problem hiding this comment.
Looks like you need to define a dummy value of _expanded_dist_path when get_backend() == "numpy" to get test collection to work, even though the tests themselves are all skipped.
eb8680
approved these changes
Jan 10, 2021
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #418.
Though we can eagerly expand distributions, as in https://github.com/pyro-ppl/numpyro/pull/809/files, it might be better to not have to think about doing so each time we want to use funsor. :D