Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Docker build management #103

Closed
frgfm opened this issue Aug 5, 2022 · 1 comment · Fixed by #106
Closed

[docker] Docker build management #103

frgfm opened this issue Aug 5, 2022 · 1 comment · Fixed by #106
Assignees
Labels
Milestone

Comments

@frgfm
Copy link
Member

frgfm commented Aug 5, 2022

Hey there 👋

As discussed offline, we need to handle docker containers efficiently for this repo as it is critical for deployment.
Here is my suggestion:

  • it is mandatory that the DockerHub repo https://hub.docker.com/repository/docker/pyronear/pyro-engine has the latest ARM images.
  • CI docker push frequency: either we push at each merged PR, or at each release. I suggest doing those on releases, we can increase the release pace to use patch index (i.e. 0.1.1, 0.1.2, etc.)
  • tag management : latest version should be pushed to the tag latest. Additionally, it should also be pushed to a descriptive tag: for instance, as of right now, the image is based on python:3.8.1-slim, so the tag should be python3.8.1-slim.
  • device update: once pushed to dockerhub, a digest hash is created. This should be the reference for the software hash of the device.
  • optionally, if we can manage to push to DockerHub the linux build as well (not overriding the ARM one), that would be nice 👍

Any suggestion is welcome!

@frgfm frgfm added this to the 0.2.0 milestone Aug 5, 2022
@frgfm frgfm self-assigned this Aug 5, 2022
@frgfm
Copy link
Member Author

frgfm commented Aug 6, 2022

Closed by #106

@frgfm frgfm closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant