Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added multi-arch docker build upon release #106

Merged
merged 3 commits into from
Aug 5, 2022
Merged

ci: Added multi-arch docker build upon release #106

merged 3 commits into from
Aug 5, 2022

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Aug 5, 2022

This PR adds a CI job to build and push docker images for both linux/amd64 and linux/arm64, following this tutorial: https://dev.to/cloudx/multi-arch-docker-images-the-easy-way-with-github-actions-4k54

Closes #103

Any feedback is welcome!

@frgfm frgfm added this to the 0.2.0 milestone Aug 5, 2022
@frgfm frgfm requested a review from a team August 5, 2022 10:43
@frgfm frgfm self-assigned this Aug 5, 2022
@frgfm frgfm changed the base branch from develop to main August 5, 2022 10:43
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #106 (2c3a4f4) into main (731391c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   67.90%   67.90%           
=======================================
  Files           3        3           
  Lines         162      162           
=======================================
  Hits          110      110           
  Misses         52       52           
Flag Coverage Δ
unittests 67.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is much easier with buildx ! did you test it ?

@frgfm
Copy link
Member Author

frgfm commented Aug 5, 2022

@MateoLostanlen not yet, it will be triggered on the next release!
If it fails, I'll trigger it manually and fix the job 👌

@frgfm frgfm merged commit da7f87e into main Aug 5, 2022
@frgfm frgfm deleted the docker-build branch August 5, 2022 17:10
@MateoLostanlen
Copy link
Member

Ok thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docker] Docker build management
2 participants