Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added unittests with Alert API #108

Merged
merged 4 commits into from
Aug 6, 2022
Merged

test: Added unittests with Alert API #108

merged 4 commits into from
Aug 6, 2022

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Aug 5, 2022

This PR introduces the following modifications:

  • updates test dependencies
  • passes down .env from the CI
  • adds unittests with the API
  • improves logging in Engine
  • renames client_creds into cam_creds
  • fixes edge case for state update
  • return HTTP response in private methods (for unittests)

Closes #51

Any feedback is welcome!

@frgfm frgfm added this to the 0.2.0 milestone Aug 5, 2022
@frgfm frgfm requested a review from a team August 5, 2022 19:14
@frgfm frgfm self-assigned this Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #108 (c6b6903) into main (731391c) will increase coverage by 27.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #108       +/-   ##
===========================================
+ Coverage   67.90%   95.15%   +27.25%     
===========================================
  Files           3        3               
  Lines         162      165        +3     
===========================================
+ Hits          110      157       +47     
+ Misses         52        8       -44     
Flag Coverage Δ
unittests 95.15% <100.00%> (+27.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyroengine/core.py 94.20% <100.00%> (+32.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frgfm
Copy link
Member Author

frgfm commented Aug 5, 2022

All good, and now we got 94% of coverage 😁

@frgfm frgfm merged commit 33a2904 into main Aug 6, 2022
@frgfm frgfm deleted the api-tests branch August 6, 2022 16:06
@frgfm frgfm linked an issue Aug 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Adds unittests to check API interactions within pyroengine
1 participant