Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save img for debug #92

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Conversation

MateoLostanlen
Copy link
Member

It can be useful to save the images on the pi for debug purposes. This PR adds this option, you just have to add a variable save_img_debug to config_data.json:


{
    "detection_threshold": 0.25,
    "api_url": "https://api.pyronear.org",
    "save_evry_n_frame": 50,
    "loop_time": 7.5,
    "latitude": 48.8673439026,
    "longitude": 2.3841824532,
    "model_weights": "data/yolov5s_v001.onnx",
    "save_img_debug": True,
}

@MateoLostanlen MateoLostanlen requested a review from frgfm July 20, 2022 07:09
@MateoLostanlen MateoLostanlen self-assigned this Jul 20, 2022
@MateoLostanlen MateoLostanlen added the type: enhancement New feature or request label Jul 20, 2022
@MateoLostanlen MateoLostanlen force-pushed the feature/save_img_debug branch from 89d08e9 to bf1e51b Compare July 20, 2022 07:17
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #92 (ab9fc4d) into develop (8029738) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #92   +/-   ##
========================================
  Coverage    63.68%   63.68%           
========================================
  Files            5        5           
  Lines          179      179           
========================================
  Hits           114      114           
  Misses          65       65           
Flag Coverage Δ
unittests 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There is one typo I think

Also, can you explain what this is for?
I thought this was the script to trigger multi picture taking, but it's for the regular picture saving ?

runner/src/runner.py Outdated Show resolved Hide resolved
runner/src/runner.py Show resolved Hide resolved
runner/src/runner.py Outdated Show resolved Hide resolved
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@frgfm frgfm merged commit 245cd1d into pyronear:develop Jul 20, 2022
@MateoLostanlen MateoLostanlen deleted the feature/save_img_debug branch July 24, 2022 17:21
@frgfm frgfm added type: new feature ext: src and removed type: enhancement New feature or request labels Aug 7, 2022
@frgfm frgfm added this to the 0.2.0 milestone Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants