Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace map().unwrap_or_else() #255

Merged
merged 1 commit into from
Jan 2, 2025
Merged

refactor: replace map().unwrap_or_else() #255

merged 1 commit into from
Jan 2, 2025

Conversation

hamirmahal
Copy link
Contributor

Closes #254

hamirmahal
hamirmahal commented Jan 1, 2025
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed on a fork.

@pyrossh
Copy link
Owner

pyrossh commented Jan 2, 2025

LGTM. Thanks @hamirmahal

@pyrossh pyrossh merged commit 2e69081 into pyrossh:master Jan 2, 2025
5 checks passed
@hamirmahal hamirmahal deleted the refactor/replace-map-unwrap-or-else branch January 2, 2025 23:47
@hamirmahal
Copy link
Contributor Author

You're welcome @pyrossh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl/src/lib.rs readability improvement
2 participants
@hamirmahal @pyrossh