Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: fix target #88

Merged
merged 7 commits into from
Feb 27, 2023
Merged

GHA: fix target #88

merged 7 commits into from
Feb 27, 2023

Conversation

martinfleis
Copy link
Member

@jGaboardi wrong branch...

@jGaboardi jGaboardi self-assigned this Feb 27, 2023
@jGaboardi
Copy link
Member

We should make a note to swap this target branch back to main once we can change the default branch.

@martinfleis
Copy link
Member Author

I even think that the Github feature does that for you.

@jGaboardi
Copy link
Member

xref #64

ci/envs/310-latest.yaml Outdated Show resolved Hide resolved
@martinfleis
Copy link
Member Author

It seems that this is now working as expected. I see the same two failures locally. One seem to be dealt with in #69 and the other one seems to be some tiny difference, so change in tolerance should do the trick.

@martinfleis
Copy link
Member Author

I suggest merging this once the remaining envs finish and update #69 from master. We should also see if this fixed RTD.

@martinfleis
Copy link
Member Author

Also, we can then merge bits of #64 that are still relevant.

@jGaboardi
Copy link
Member

I suggest merging this once the remaining envs finish and update #69 from master. We should also see if this fixed RTD.

Works for me.

@martinfleis martinfleis merged commit 5e2922f into pysal:master Feb 27, 2023
@martinfleis martinfleis deleted the target branch February 27, 2023 21:58
@martinfleis
Copy link
Member Author

@jGaboardi
Copy link
Member

Awesome work on this @martinfleis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants