Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to v2.3.0 #94

Merged
merged 1 commit into from
Mar 6, 2023
Merged

bump to v2.3.0 #94

merged 1 commit into from
Mar 6, 2023

Conversation

weikang9009
Copy link
Member

#93

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #94 (8ffe884) into main (08a7ada) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files          12       12           
  Lines        1841     1841           
  Branches      315      315           
=======================================
  Hits          966      966           
  Misses        819      819           
  Partials       56       56           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@weikang9009
Copy link
Member Author

@ljwolf Can you check if the API for the distance-based functions is correct? If yes, I will push for a release of pointpats 2.3.0

@martinfleis
Copy link
Member

Hmm, we should probably update the versioning tools so this gets retrieved from the tag. @jGaboardi Is setuptools_scm where we're going now?

@martinfleis
Copy link
Member

To clarify - it is not strictly needed but the tooling we have elsewhere allows you to just add the tag and the version is fetched from that.

@ljwolf
Copy link
Member

ljwolf commented Mar 6, 2023

Yes, as far as I can tell, the API for the distance statistics is correct, and shows up correctly in the doc build! Go ahead and tag + release on PyPI!

@ljwolf ljwolf merged commit 6866863 into pysal:main Mar 6, 2023
@martinfleis
Copy link
Member

PyPI release should happen automatically once the tag is pushed via https://github.com/pysal/pointpats/blob/main/.github/workflows/release_and_publish.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants