update release workflow #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knaaptime
commented
Aug 1, 2023
.github/workflows/upload_package.yml
Outdated
| python -m build | ||
| twine check --strict dist/* | ||
| pip install setuptools wheel twine jupyter urllib3 pandas pyyaml | ||
| python setup.py sdist bdist_wheel |
There was a problem hiding this comment.
@jGaboardi does this line with setup.py still work with pyproject.toml? I thought you had to use pip install . ?
There was a problem hiding this comment.
See here in spaghetti's release workflow.
There was a problem hiding this comment.
ah ok thanks. I snagged the last one from spopt
There was a problem hiding this comment.
Have not had enough time recently to sync everything 😰
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
===========================================
+ Coverage 71.38% 81.88% +10.50%
===========================================
Files 67 66 -1
Lines 2628 2291 -337
===========================================
Hits 1876 1876
+ Misses 752 415 -337 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.