Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize tqdm progress bar in Skater #332

Closed
Tracked by #331
jGaboardi opened this issue Jan 6, 2023 · 5 comments · Fixed by #333
Closed
Tracked by #331

customize tqdm progress bar in Skater #332

jGaboardi opened this issue Jan 6, 2023 · 5 comments · Fixed by #333
Assignees

Comments

@jGaboardi
Copy link
Member

The tqdm progress bar in Skater could use some customization to make it less wide. Probably simply changing to tqdm.auto, as in momepy.graph.py, would do the trick.

@knaaptime
Copy link
Member

not sure if there's a way to control the width, specifically, but i havent really looked. Moving the import from auto will give you the fancy progress bar in a jupyter notebook (with ipywidgets) but fallback to the block style if you're in a terminal

also, do we have a test case for when tqdm is not installed? Pretty sure this line will fail cause noop isnt defined and should be pass instead?

@knaaptime
Copy link
Member

ah, nvm. read too quickly

@jGaboardi jGaboardi mentioned this issue Jan 6, 2023
4 tasks
@jGaboardi
Copy link
Member Author

also, do we have a test case for when tqdm is not installed? Pretty sure this line will fail cause noop isnt defined and should be pass instead?

Recently I added coverage for those lines (see codecov here). I added the /.ci/38-MIN.yaml specifically without tqdm for testing. The noop is only defined as a parameter within the context of a stand-in tqdm function.

@knaaptime
Copy link
Member

nice.

yeah i realized shortly it was input to the passthrough function defined just above... i was looking for it to be defined somewhere in the outer function. oops 😛

@jGaboardi
Copy link
Member Author

ah, nvm. read too quickly

... I've never done that before... 🙊 😹

jGaboardi added a commit to jGaboardi/spopt that referenced this issue Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants