Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install pulp for docs build #205

Merged
merged 1 commit into from
Nov 3, 2021
Merged

install pulp for docs build #205

merged 1 commit into from
Nov 3, 2021

Conversation

jGaboardi
Copy link
Member

Seems that we need to install pulp for docs build. See failure here.

@jGaboardi jGaboardi requested a review from gegen07 November 3, 2021 00:48
@jGaboardi jGaboardi self-assigned this Nov 3, 2021
@jGaboardi jGaboardi added bug Something isn't working docs labels Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #205 (7e64b62) into main (7c89cf6) will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #205     +/-   ##
=======================================
+ Coverage   65.1%   65.3%   +0.2%     
=======================================
  Files         23      23             
  Lines       2461    2461             
  Branches     494     494             
=======================================
+ Hits        1602    1608      +6     
+ Misses       786     777      -9     
- Partials      73      76      +3     
Impacted Files Coverage Δ
spopt/_version.py 34.1% <0.0%> (+1.8%) ⬆️

@jGaboardi
Copy link
Member Author

Doc build locally without an issue after applying this fix. After this is merged we can do a v0.2.1 release and simply copy over the v0.2.0 Release Notes. Then we'll let JOSS know we are ready for reviewing to resume 🎉 .

@jGaboardi jGaboardi merged commit a9cda4f into main Nov 3, 2021
@jGaboardi jGaboardi deleted the jGaboardi-patch-1 branch November 3, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants