-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add predefined locations to coverage models #231
Add predefined locations to coverage models #231
Conversation
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
=======================================
+ Coverage 65.8% 66.1% +0.4%
=======================================
Files 23 23
Lines 2535 2554 +19
Branches 552 559 +7
=======================================
+ Hits 1667 1689 +22
+ Misses 787 779 -8
- Partials 81 86 +5
|
This is a very nice start @gegen07! |
I just realized that we are not assigning decision variable labels for plotting, but only using the |
In the MCLP notebook we have different labels in the legend. |
ah! You are right about that, I completely misread the legend. My fault. Though it is still good to have a defined color map so that a specific color is tied to a specific facility. Then the two plots in the notebook are easier to compare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unbelievably great work @gegen07. Let's also try to get a reviews from Qunshan and Levi if they have time. But it looks great to me.
@qszhao Got time for a review? |
I think this is probably good to go and we can go ahead and merge. 🎉 |
Thanks @jGaboardi and @gegen07! Great to have this question sorted out! |
Based on ideas raised in discussion #218.
I'm trying to implement @jGaboardi idea, for instance.