Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a 'final' proofing for JOSS manuscript #252

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jun 13, 2022

This PR partially addresses #251 by

  • proofing a "final" for typos, grammar, coherency, etc.
  • correcting broken links
  • adding a scikit-learn citation

xref openjournals/joss-reviews#3330

@jGaboardi jGaboardi added the JOSS label Jun 13, 2022
@jGaboardi jGaboardi self-assigned this Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #252 (64f0e9d) into main (2351de9) will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #252     +/-   ##
=======================================
+ Coverage   66.1%   66.3%   +0.2%     
=======================================
  Files         23      23             
  Lines       2582    2582             
  Branches     566     566             
=======================================
+ Hits        1706    1711      +5     
+ Misses       790     781      -9     
- Partials      86      90      +4     
Impacted Files Coverage Δ
spopt/_version.py 33.8% <0.0%> (+1.5%) ⬆️

@jGaboardi jGaboardi merged commit abc3a76 into pysal:main Jun 13, 2022
@jGaboardi jGaboardi deleted the final_proof branch June 13, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant