Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bounds for client assignment variables #336

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jan 10, 2023

This PR resolves #328. Following merge we can cut release v0.5.0 🎉

xref #331

@jGaboardi jGaboardi requested review from gegen07 and ljwolf January 10, 2023 23:08
@jGaboardi jGaboardi self-assigned this Jan 10, 2023
@jGaboardi jGaboardi added bug Something isn't working locate labels Jan 10, 2023
@jGaboardi jGaboardi mentioned this pull request Jan 10, 2023
4 tasks
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #336 (54208a6) into main (13c0ddc) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #336   +/-   ##
=====================================
  Coverage   74.0%   74.0%           
=====================================
  Files         23      23           
  Lines       2477    2477           
  Branches     513     513           
=====================================
  Hits        1833    1833           
  Misses       580     580           
  Partials      64      64           
Impacted Files Coverage Δ
spopt/locate/base.py 93.6% <100.0%> (ø)
spopt/locate/coverage.py 95.6% <100.0%> (ø)
spopt/locate/p_center.py 100.0% <100.0%> (ø)
spopt/locate/p_median.py 100.0% <100.0%> (ø)

@jGaboardi jGaboardi changed the title [BUG] bounds client assignment variables [BUG] bounds for client assignment variables Jan 11, 2023
Copy link
Member

@gegen07 gegen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@gegen07 gegen07 merged commit 6e382b6 into pysal:main Jan 12, 2023
@jGaboardi jGaboardi deleted the clscp_var_bug branch January 12, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working locate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] client assignment variable bounds for CLSCP-SO
2 participants