Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapely>=2 & other minimum version deps #377

Merged
merged 11 commits into from
May 29, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi requested a review from sjsrey May 27, 2023 17:01
@jGaboardi
Copy link
Member Author

jGaboardi commented May 27, 2023

Looks like even python==3.8 is causing problems. Perhaps time to dump that and support only python>=3.9.

resolved by keeping geopandas==0.10 as minimum

cc @sjsrey @martinfleis @gegen07 @knaaptime @ljwolf

@sjsrey
Copy link
Member

sjsrey commented May 27, 2023

In this specific case that makes sense. More broadly we might think of adopting a policy of supporting say the last three stable versions of Python?

If we did that, we'd have a decision rule as to when to drop previous versions on a case by case basis.

@jGaboardi
Copy link
Member Author

jGaboardi commented May 28, 2023

No idea why I am not able to get this 3.9 minimum CI environment to solve...

geopandas==0.12 was the problem

@martinfleis
Copy link
Member

We should follow https://scientific-python.org/specs/spec-0000/ in regards to versions. Including Python. We can deviate when it makes sense (shapely 2).

@jGaboardi jGaboardi changed the title shapely & geopandas version bump shapely>=2 & other minimum version deps May 28, 2023
@jGaboardi
Copy link
Member Author

I finally realized the problem was specifically with the geopandas==0.12 pin, which was not necessary. Keeping the pin at geopandas==0.10 allows for Python 3.8 environment resolution.

@jGaboardi jGaboardi self-assigned this May 28, 2023
@jGaboardi jGaboardi added CI dependencies Pull requests that update a dependency file labels May 28, 2023
@jGaboardi jGaboardi requested a review from martinfleis May 28, 2023 14:05
.ci/38-MIN.yaml Outdated Show resolved Hide resolved
.ci/38-MIN.yaml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Show resolved Hide resolved
@jGaboardi jGaboardi requested a review from martinfleis May 29, 2023 19:31
@jGaboardi jGaboardi merged commit 0ce3b84 into pysal:main May 29, 2023
@jGaboardi jGaboardi deleted the bump_min_shapely branch May 29, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update micromamba setup in CI stipulate minimum shapely version Failing CI: geopandas + spaghetti
3 participants