Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend capacitated model name #417

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Prepend capacitated model name #417

merged 2 commits into from
Dec 7, 2023

Conversation

jGaboardi
Copy link
Member

This PR resolves #416

@jGaboardi jGaboardi requested a review from gegen07 December 3, 2023 23:35
@jGaboardi jGaboardi self-assigned this Dec 3, 2023
@jGaboardi jGaboardi mentioned this pull request Dec 3, 2023
Closed
25 tasks
@jGaboardi jGaboardi requested a review from ljwolf December 4, 2023 13:46
@jGaboardi
Copy link
Member Author

@gegen07 @ljwolf gentle ping for quick review; this is a 3-liner.

gegen07
gegen07 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@gegen07 gegen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the late reply.

@gegen07 gegen07 merged commit bf7134a into pysal:main Dec 7, 2023
10 checks passed
@jGaboardi
Copy link
Member Author

Looks good to me! Sorry for the late reply.

Thanks! No problem at all.

@jGaboardi jGaboardi deleted the update_capacitated_name branch December 7, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gegen07 gegen07 gegen07 approved these changes

@ljwolf ljwolf Awaiting requested review from ljwolf

Assignees

@jGaboardi jGaboardi

Labels
locate rough edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent "capacitated" model name label
2 participants
@jGaboardi @gegen07