Review messaging in KN-PMP #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 27 27
Lines 2638 2638
=====================================
Hits 2053 2053
Misses 585 585
|
|
I need to update the test for this. Will push up a fix shortly. |
ljwolf
approved these changes
Dec 10, 2023
ljwolf
reviewed
Dec 10, 2023
| @@ -547,7 +547,7 @@ def solve(self, solver: pulp.LpSolver, results: bool = True): | |||
| class KNearestPMedian(PMedian): | |||
| r""" | |||
| Implement the P-Median Model with Near-Far Cost Allocation and solve it. | |||
| The model is adapted from :cite:`richard_2018`, can be formulated as: | |||
| The model is adapted from :cite:`richard_2018`, and can be formulated as: | |||
There was a problem hiding this comment.
This should probably be keyed "church_2018", no?
There was a problem hiding this comment.
Anyway, I don't mind if it's not.
There was a problem hiding this comment.
Looks like it snuck in as richard_2018 .
There was a problem hiding this comment.
I'll throw in a quick PR for a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR:
xref #414