Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix numpy=2.0.0 compat -- #456 #457

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

jGaboardi
Copy link
Member

This PR resolves #456

@jGaboardi jGaboardi requested a review from gegen07 June 19, 2024 23:25
@jGaboardi jGaboardi self-assigned this Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (9707567) to head (7c06f4c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #457   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files         27      27           
  Lines       2638    2638           
=====================================
  Hits        2053    2053           
  Misses       585     585           
Files Coverage Δ
spopt/region/maxp.py 98.0% <100.0%> (ø)

@jGaboardi jGaboardi changed the title fix numpy 20 compat -- #456 fix numpy 2.0 compat -- #456 Jun 19, 2024
@jGaboardi jGaboardi changed the title fix numpy 2.0 compat -- #456 fix numpy=2.0.0 compat -- #456 Jun 19, 2024
@jGaboardi jGaboardi requested a review from knaaptime June 19, 2024 23:41
@gegen07 gegen07 merged commit 6ec4ec1 into pysal:main Jun 20, 2024
11 checks passed
@jGaboardi jGaboardi deleted the GH456__numpy20_compt branch June 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy>=2.0 failures -- [2024-06-19]
2 participants