-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean warning update #129
base: develop
Are you sure you want to change the base?
Clean warning update #129
Conversation
Created a general clean warning variable for the general clean method.
Added the `_clean_warn` test attribute to the existing model Instruments.
Added a description of the changes to the log.
Pandas changed their behaviour at some point, added a try/except loop to ensure the missing time selection works regardless of the available kwargs.
Removed extra whitespace.
@jklenzing there's a problem with the pysatNASA integration 😿 |
|
I think you just need to update the data_path usage |
Updated the minimum version of pysatNASA and changed the download behaviour.
Update the tests run, partially complying with new standards.
Remove the pandas version limit to support earlier versions of python.
Ok @jklenzing any idea why pysatNASA isn't importing in these test? 🦦 |
Cycle the supported python versions.
Fixed the commands that expected us to have a pyproject.toml file.
Making some hopeful changes.
Forgot to add the file suffixes.
Coverage dropped to zero, this might fix it.
Update operational test version limits. Co-authored-by: Jeff Klenzing <19592220+jklenzing@users.noreply.github.com>
Added a debug line to see if pysatNASA is being installed correctly before trying the pysatModels unit tests.
…Models into clean_warning_update
Added another import to see if pysatNASA can eventually succeed.
See what and where python is.
I've managed to generate a different error locally in a python 3.7 virtual environment after downgrading to pip 21.3.1 (same as in the GA workflow) and attempting to install pysatNASA. I get an ImportError for |
Description
Addresses pysat/pysat#1129 changes by adding the new test attribute to the existing model Instruments.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran unit tests locally with the new pysat updates.
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release