Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: RC test fixes #168

Merged
merged 27 commits into from
May 24, 2023
Merged

TST: RC test fixes #168

merged 27 commits into from
May 24, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Apr 26, 2023

Description

Updates several bugs in the RC testing due to new behaviour at Github Actions.

  • --no_binary is removed in latest pip
  • updated flake8 expands definitions of E275 (no whitespace after keyword) to include raise
  • Use --pre for pip to include pre-release versions at test pypi
  • Use --extra-index-url to support wheel builds

pysatCDF tests removed for the time being (documented in #167).

Adds a yml to manage readthedocs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

At github actions. Include manual run of pysat_rc workflow for this branch to test with pysat/pysat#1116

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing mentioned this pull request Apr 26, 2023
25 tasks
@jklenzing jklenzing marked this pull request as ready for review April 26, 2023 19:29
@jklenzing
Copy link
Member Author

python 3.10 on windows expected to fail. Updates to pysat in the RC have fixed these. See: https://github.com/pysat/pysatNASA/actions/runs/4812031229

@jklenzing jklenzing mentioned this pull request May 5, 2023
11 tasks
@jklenzing
Copy link
Member Author

The readthedocs buld was failing, potentially caused by a new release of urllib3. See https://readthedocs.org/projects/pysatnasa/builds/20451047/

Added a readthedocs.yml according to the instructions, which appears to fix the issue. Note the default install was using python 3.7.

CHANGELOG.md Outdated Show resolved Hide resolved
@jklenzing jklenzing requested a review from aburrell May 9, 2023 19:59
.github/workflows/main.yml Outdated Show resolved Hide resolved
.readthedocs.yml Outdated Show resolved Hide resolved
.readthedocs.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pysatNASA/tests/test_instruments.py Outdated Show resolved Hide resolved
jklenzing and others added 2 commits May 16, 2023 13:39
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing
Copy link
Member Author

@JonathonMSmith is --no-cache-dir what we want here? Or do we need a different option?

@JonathonMSmith
Copy link
Collaborator

@jklenzing If we use --no-cache-dir I think pip will still favor wheels. If we want to avoid downloading wheels, then we need the --no-binary option as well. This is the --no-binary deprecation issue.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@jklenzing
Copy link
Member Author

@jklenzing If we use --no-cache-dir I think pip will still favor wheels. If we want to avoid downloading wheels, then we need the --no-binary option as well. This is the --no-binary deprecation issue.

OK. looking through the code, the no-binary option is required to get pysatCDF to build correctly. However, since there are other problems with that and we've shut off the tests for now, we can just build the older numpy as usual.

.readthedocs.yml Outdated Show resolved Hide resolved
@jklenzing
Copy link
Member Author

@JonathonMSmith, can you take a look at the final config? This should be good to go, but I'd like another set of eyes on this.

@jklenzing jklenzing merged commit 13b12c4 into develop May 24, 2023
@jklenzing jklenzing deleted the tst/rc_fix branch May 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants