Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on fzf, even with ANI_CLI_PLAYER=debug, -S and -e #1187

Closed
port19x opened this issue Aug 2, 2023 · 3 comments · Fixed by #1189
Closed

Depends on fzf, even with ANI_CLI_PLAYER=debug, -S and -e #1187

port19x opened this issue Aug 2, 2023 · 3 comments · Fixed by #1189
Assignees
Labels
category: ui ux Everything ui / ux priority 2: medium Default for bugs type: bug something isn't working

Comments

@port19x
Copy link
Collaborator

port19x commented Aug 2, 2023

Metadata (please complete the following information)
Version: 4.5.4
OS: Arch Linux
Shell: zsh
Anime: -

Describe the bug

Steps To Reproduce

  1. Uninstall fzf if present
  2. Run export ANI_CLI_PLAYER="debug"
  3. Run ani-cli -S 1 -e 1 flcl

Expected behavior
fzf should not be required when no interactive menu is used.

Screenshots (if applicable; you can just drag the image onto github)

Additional context
I want to containerize this and make an api, as in my proof of concept: foxproxy

@port19x port19x added type: bug something isn't working priority 2: medium Default for bugs labels Aug 2, 2023
@Derisis13
Copy link
Collaborator

it'd only take an extra line and a lot of conditions to make fzf checked when all of those is false

@port19x
Copy link
Collaborator Author

port19x commented Aug 3, 2023

Probably some other environment variable makes sense here

@CoolnsX
Copy link
Collaborator

CoolnsX commented Aug 3, 2023

ye, how would you select anime in interactive session?

@port19x port19x self-assigned this Aug 6, 2023
@port19x port19x added the category: ui ux Everything ui / ux label Aug 6, 2023
@justchokingaround justchokingaround linked a pull request Aug 6, 2023 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ui ux Everything ui / ux priority 2: medium Default for bugs type: bug something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants