Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proper non-interactive-mechanic #1189

Merged
merged 7 commits into from
Aug 7, 2023
Merged

feat: proper non-interactive-mechanic #1189

merged 7 commits into from
Aug 7, 2023

Conversation

justchokingaround
Copy link
Collaborator

@justchokingaround justchokingaround commented Aug 6, 2023 •
edited by port19x
Loading

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@justchokingaround justchokingaround linked an issue Aug 6, 2023 that may be closed by this pull request
Depends on fzf, even with ANI_CLI_PLAYER=debug, -S and -e #1187
Closed
@justchokingaround
Copy link
Collaborator Author

fuck version bump, i ain't no bitch

port19x
port19x requested changes Aug 6, 2023
View reviewed changes
ani-cli Show resolved Hide resolved
@port19x port19x requested a review from Derisis13 as a code owner August 7, 2023 05:37
@port19x
Copy link
Collaborator

port19x commented Aug 7, 2023

I haven't thoroughly tested my change yet, but should be good

@port19x port19x self-requested a review August 7, 2023 05:48
@port19x
Copy link
Collaborator

port19x commented Aug 7, 2023 •
edited
Loading

I'd prefer another review before merge, as I added some lines too
yolo

@port19x port19x changed the title fix: force http in video link feat: proper non-interactive-mechanic Aug 7, 2023
@port19x
Copy link
Collaborator

port19x commented Aug 7, 2023

Renamed to reflect the more impactful change

@port19x port19x merged commit cc1ea80 into master Aug 7, 2023
@port19x port19x deleted the windows-bug branch August 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@port19x port19x port19x approved these changes

@Derisis13 Derisis13 Awaiting requested review from Derisis13 Derisis13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depends on fzf, even with ANI_CLI_PLAYER=debug, -S and -e
2 participants
@justchokingaround @port19x