Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update demo video #1060

Merged
merged 1 commit into from
Mar 13, 2023
Merged

docs: update demo video #1060

merged 1 commit into from
Mar 13, 2023

Conversation

justchokingaround
Copy link
Collaborator

@justchokingaround justchokingaround commented Mar 13, 2023 •
edited
Loading

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@71zenith 71zenith self-requested a review March 13, 2023 10:45
@justchokingaround justchokingaround linked an issue Mar 13, 2023 that may be closed by this pull request
docs: showcase video broken #1058
Closed
@port19x port19x merged commit 383f34f into master Mar 13, 2023
@port19x port19x deleted the showcase-video branch March 13, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@71zenith 71zenith 71zenith approved these changes

@port19x port19x port19x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: showcase video broken
3 participants
@justchokingaround @port19x @71zenith