style: consistent 4 space indentation + shfmt #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💀 how does this break shellcheck this bad |
|
Oh, Line 360 |
71zenith
approved these changes
Apr 9, 2023
|
Can we get rewrite the lines at 360 to not include |
|
https://google.github.io/styleguide/shellguide.html Google thinks 2 spaces are better than 4 spaces for shell |
|
Anyway, let's do 4 spaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of change
Description
I normalized indentation to 4 spaces and ran ani-cli through shfmt, which mainly fixed some case statements
Prior inconsistency
Checklist