Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add non-interactive flag to disable menu #1107

Merged
merged 3 commits into from
May 4, 2023
Merged

feat: add non-interactive flag to disable menu #1107

merged 3 commits into from
May 4, 2023

Conversation

RubenPonce
Copy link
Contributor

@RubenPonce RubenPonce commented May 2, 2023 •
edited
Loading

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

add a --non-interactive and -N flag to disable the menu. Mentioned in #1104
demo

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@RubenPonce RubenPonce requested a review from port19x as a code owner May 2, 2023 18:50
port19x
port19x requested changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix shellcheck pls. Otherwise looks good

@RubenPonce RubenPonce requested a review from port19x May 3, 2023 18:29
port19x
port19x approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@port19x port19x merged commit 0ccedf1 into pystardust:master May 4, 2023
@port19x port19x mentioned this pull request May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@port19x port19x port19x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubenPonce @port19x